<html>
<head><meta charset="utf-8"><title>Transition to the Octocrab GitHub API · t-release/triagebot · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/index.html">t-release/triagebot</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html">Transition to the Octocrab GitHub API</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="197730246"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197730246" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197730246">(May 15 2020 at 18:06)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> <span class="user-mention" data-user-id="219696">@XAMPPRocky</span> Created a new topic to discuss about Octocrab <span aria-label="innocent" class="emoji emoji-1f607" role="img" title="innocent">:innocent:</span></p>



<a name="197730257"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197730257" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197730257">(May 15 2020 at 18:06)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I’m unsure if I should use a static instance (<code>Octocrab::instance</code>), or store the Octocrab client just like how we store the <code>GithubClient</code> today, passing it as context to any function that might need it...</p>



<a name="197730372"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197730372" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197730372">(May 15 2020 at 18:07)</a>:</h4>
<p>Do you have a preference, or arguments about how it affects performance? I have absolutely no idea of the drawbacks of both approaches</p>



<a name="197730578"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197730578" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197730578">(May 15 2020 at 18:09)</a>:</h4>
<p>Please don't use the global</p>



<a name="197730619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197730619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197730619">(May 15 2020 at 18:09)</a>:</h4>
<p>That's just generally more painful in the long run</p>



<a name="197734490"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197734490" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197734490">(May 15 2020 at 18:40)</a>:</h4>
<p>Alright</p>



<a name="197760479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197760479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197760479">(May 15 2020 at 22:42)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> <a href="https://github.com/LeSeulArtichaut/triagebot">https://github.com/LeSeulArtichaut/triagebot</a> is this the repo you are working in?</p>



<a name="197766508"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197766508" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197766508">(May 16 2020 at 00:27)</a>:</h4>
<p>Yes, but I haven't pushed anything yet <span aria-label="confused" class="emoji emoji-1f615" role="img" title="confused">:confused:</span></p>



<a name="197817257"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197817257" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197817257">(May 16 2020 at 22:00)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> A bit of a stupid question, but how would I actually create the "diff" for a PR with octograb?</p>



<a name="197817349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197817349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197817349">(May 16 2020 at 22:02)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> I haven’t implemented that API yet so you need to use the HTTP API for now.</p>



<a name="197817426"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197817426" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197817426">(May 16 2020 at 22:04)</a>:</h4>
<p>You need to set a custom media type. <a href="https://developer.github.com/v3/pulls/#custom-media-types">https://developer.github.com/v3/pulls/#custom-media-types</a></p>



<a name="197817507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197817507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197817507">(May 16 2020 at 22:07)</a>:</h4>
<p>I can also try help implementing some things in Octocrab</p>



<a name="197834735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197834735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197834735">(May 17 2020 at 07:03)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Okay, I've just pushed to master a API that should allow to get a diff or patch with <code>pulls().get_diff</code> and <code>pulls().get_patch</code>. Try it out, and if there's no bugs I'll release it soon.</p>



<a name="197834741"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197834741" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197834741">(May 17 2020 at 07:03)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> Thanks for being so helpful, I've reviewed your PRs now. <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="197840398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197840398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197840398">(May 17 2020 at 09:45)</a>:</h4>
<p>I've just released 0.2.3 which has the get diff and patch methods as well adds the markdown api and the gitignore api.</p>



<a name="197927204"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197927204" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197927204">(May 18 2020 at 12:30)</a>:</h4>
<p>Is there an easy tool for creating a patch/diff?</p>



<a name="197930046"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197930046" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197930046">(May 18 2020 at 12:58)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Oh sorry I see what you meant now. You would need to use the Git Data API. <a href="https://developer.github.com/v3/git/">https://developer.github.com/v3/git/</a></p>



<a name="197930405"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197930405" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197930405">(May 18 2020 at 13:01)</a>:</h4>
<p>You don't create a patch or diff to send, you commit to a branch.</p>



<a name="197935486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197935486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197935486">(May 18 2020 at 13:38)</a>:</h4>
<p>You might have an easier time using <code>git2</code> directly.</p>



<a name="197936052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197936052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197936052">(May 18 2020 at 13:42)</a>:</h4>
<p>git2 probably requires a file system which we ~don't have</p>



<a name="197936889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197936889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197936889">(May 18 2020 at 13:48)</a>:</h4>
<p>well it can be reset at any point, but we have it</p>



<a name="197938384"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197938384" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197938384">(May 18 2020 at 14:00)</a>:</h4>
<p>hm okay -- that seems like a road to needing integrity checks all over the place and such, I'd rather avoid it if possible</p>



<a name="197959507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197959507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197959507">(May 18 2020 at 16:24)</a>:</h4>
<p>I'll think about possible solutions then! Perhaps it opens up an issue with a link to the code? Still easier than us having to find them in the list of ICEs</p>



<a name="197960314"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197960314" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197960314">(May 18 2020 at 16:29)</a>:</h4>
<p>it should be possible to do everything through the github api  I think</p>



<a name="197961112"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197961112" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197961112">(May 18 2020 at 16:35)</a>:</h4>
<p>To open a PR with changes purely through the API? I only found how to open a PR between branches</p>



<a name="197966248"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197966248" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197966248">(May 18 2020 at 17:13)</a>:</h4>
<p>well, you'd create a branch via the api and then open a pr with that branch</p>



<a name="197991200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197991200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197991200">(May 18 2020 at 20:27)</a>:</h4>
<p><a href="/user_uploads/4715/L3CDYWh82nhmhRxwM1H2SpJn/Capture-décran-2020-05-18-à-22.11.08.png">Hehe, I feel lonely</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/L3CDYWh82nhmhRxwM1H2SpJn/Capture-décran-2020-05-18-à-22.11.08.png" title="Hehe, I feel lonely"><img src="/user_uploads/4715/L3CDYWh82nhmhRxwM1H2SpJn/Capture-décran-2020-05-18-à-22.11.08.png"></a></div>



<a name="197991356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197991356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197991356">(May 18 2020 at 20:28)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> From what I've seen (from my own investigation, I mean), when you create a new file using GitHub's UI, you send a POST request to <a href="https://github.com/:owner/:repo/create/:branch/path/to/folder">https://github.com/:owner/:repo/create/:branch/path/to/folder</a></p>



<a name="197991373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197991373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197991373">(May 18 2020 at 20:28)</a>:</h4>
<p>I'm not sure if we can use that in an automated app though</p>



<a name="197991457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197991457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197991457">(May 18 2020 at 20:29)</a>:</h4>
<p>Here is the form data:</p>
<div class="codehilite"><pre><span></span><code>authenticity_token:  some_b64_token
filename: issue-xxxxx.rs
new_filename: ices/issue-xxxxx.rs
commit: 3ea91680a5c33079a76bb107ff6861bc38198678
quick_pull: rust-lang:master
pr:
content_changed: true
value: code goes here
message: commit message
placeholder_message: Create issue-xxxxx.rs
description: commit description
author_email: email
</code></pre></div>



<a name="197991795"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197991795" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197991795">(May 18 2020 at 20:32)</a>:</h4>
<p>If JavaScript is able to make that commit in the browser's sandbox, then I think it should be possible with triagebot?</p>



<a name="197991961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197991961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197991961">(May 18 2020 at 20:33)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Nevermind me, there is actually <a href="https://developer.github.com/v3/repos/contents/#create-or-update-a-file">an API endpoint</a> that allows you to create files</p>



<a name="197992185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197992185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197992185">(May 18 2020 at 20:35)</a>:</h4>
<p>There is also an API endpoint to <a href="https://developer.github.com/v3/repos/forks/#create-a-fork">crate a fork</a> but I think we can create that manually and hard-code it into triagebot?</p>



<a name="197992478"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197992478" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197992478">(May 18 2020 at 20:38)</a>:</h4>
<p><a href="https://developer.github.com/v3/git/refs/#create-a-reference">Here</a> is how you can create a branch, but you'd need to <a href="https://developer.github.com/v3/git/refs/#get-a-single-reference">get the master HEAD commit</a> first</p>



<a name="197992603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197992603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197992603">(May 18 2020 at 20:38)</a>:</h4>
<p>And I think that's all we need, right? <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="197993333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197993333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197993333">(May 18 2020 at 20:45)</a>:</h4>
<p>Thanks a lot!</p>



<a name="197993582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/197993582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#197993582">(May 18 2020 at 20:48)</a>:</h4>
<p><span class="user-mention silent" data-user-id="301348">Elinvynia</span> <a href="#narrow/stream/224082-t-release.2Ftriagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API/near/197993333">said</a>:</p>
<blockquote>
<p>Thanks a lot!</p>
</blockquote>
<p>You're welcome <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span><br>
To be fair though, most of my results don't come from GitHub's doc directly but from StackOverflow posts <span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span></p>



<a name="198068204"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198068204" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198068204">(May 19 2020 at 13:51)</a>:</h4>
<p>I'll probably start work on the repositories API soon so hopefully this functionality will be available in a day or two.</p>



<a name="198069163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198069163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198069163">(May 19 2020 at 13:57)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> Oh, I was going to implement the functionalities we'll need for triagebot. Would you mind accepting a PR with those few functionalities?</p>



<a name="198069550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198069550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198069550">(May 19 2020 at 14:00)</a>:</h4>
<p>Yeah sure.</p>



<a name="198069559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198069559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198069559">(May 19 2020 at 14:00)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="198098887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198098887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198098887">(May 19 2020 at 17:18)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> <span class="user-mention" data-user-id="301348">@Elinvynia</span> I made a small proof-of-concept program, but it created <a href="https://github.com/LeSeulArtichaut/glacier/pull/1">this</a>!</p>



<a name="198099111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099111">(May 19 2020 at 17:20)</a>:</h4>
<p>Can you share the proof of concept? I'd be interested in seeing it.</p>



<a name="198099130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099130">(May 19 2020 at 17:20)</a>:</h4>
<p>I was going to ;)</p>



<a name="198099150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099150">(May 19 2020 at 17:20)</a>:</h4>
<p>However I'm diving into a backtrace</p>



<a name="198099205"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099205" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099205">(May 19 2020 at 17:21)</a>:</h4>
<p>Octocat ran into an issue when deserializing the response to creating the PR</p>



<a name="198099255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099255">(May 19 2020 at 17:21)</a>:</h4>
<p><code>Error("invalid type: null, expected a string", line: 1, column: 1657)</code></p>



<a name="198099311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099311">(May 19 2020 at 17:21)</a>:</h4>
<p>It's a shame it doesn't give more info, like which field it issued at</p>



<a name="198099464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099464">(May 19 2020 at 17:22)</a>:</h4>
<p>Anyway here's the code:</p>
<div class="codehilite"><pre><span></span><code><span class="k">use</span><span class="w"> </span><span class="n">std</span>::<span class="n">env</span><span class="p">;</span><span class="w"></span>
<span class="k">use</span><span class="w"> </span><span class="n">octocrab</span>::<span class="n">Octocrab</span><span class="p">;</span><span class="w"></span>
<span class="k">use</span><span class="w"> </span><span class="n">octocrab</span>::<span class="n">params</span>::<span class="n">repos</span>::<span class="n">Reference</span><span class="p">;</span><span class="w"></span>
<span class="k">use</span><span class="w"> </span><span class="n">octocrab</span>::<span class="n">models</span>::<span class="n">Object</span><span class="p">;</span><span class="w"></span>

<span class="cp">#[tokio::main]</span><span class="w"></span>
<span class="k">async</span><span class="w"> </span><span class="k">fn</span> <span class="nf">main</span><span class="p">()</span><span class="w"> </span>-&gt; <span class="nc">octocrab</span>::<span class="nb">Result</span><span class="o">&lt;</span><span class="p">()</span><span class="o">&gt;</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="kd">let</span><span class="w"> </span><span class="n">octocrab</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">Octocrab</span>::<span class="n">builder</span><span class="p">()</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">personal_token</span><span class="p">(</span><span class="n">env</span>::<span class="n">var</span><span class="p">(</span><span class="s">&quot;TOKEN&quot;</span><span class="p">).</span><span class="n">expect</span><span class="p">(</span><span class="s">&quot;No GitHub token&quot;</span><span class="p">))</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">build</span><span class="p">()</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">unwrap</span><span class="p">();</span><span class="w"></span>

<span class="w">    </span><span class="kd">let</span><span class="w"> </span><span class="n">fork</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">octocrab</span><span class="p">.</span><span class="n">repos</span><span class="p">(</span><span class="s">&quot;LeSeulArtichaut&quot;</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;glacier&quot;</span><span class="p">);</span><span class="w"></span>
<span class="w">    </span><span class="kd">let</span><span class="w"> </span><span class="n">base</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">octocrab</span><span class="p">.</span><span class="n">repos</span><span class="p">(</span><span class="s">&quot;LeSeulArtichaut&quot;</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;glacier&quot;</span><span class="p">);</span><span class="w"></span>

<span class="w">    </span><span class="kd">let</span><span class="w"> </span><span class="n">master</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">base</span><span class="p">.</span><span class="n">get_ref</span><span class="p">(</span><span class="o">&amp;</span><span class="n">Reference</span>::<span class="n">Branch</span><span class="p">(</span><span class="s">&quot;master&quot;</span><span class="p">.</span><span class="n">to_string</span><span class="p">())).</span><span class="k">await</span><span class="o">?</span><span class="p">.</span><span class="n">object</span><span class="p">;</span><span class="w"></span>
<span class="w">    </span><span class="kd">let</span><span class="w"> </span><span class="n">master</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="k">if</span><span class="w"> </span><span class="kd">let</span><span class="w"> </span><span class="n">Object</span>::<span class="n">Commit</span><span class="w"> </span><span class="p">{</span><span class="w"> </span><span class="n">sha</span><span class="p">,</span><span class="w"> </span><span class="o">..</span><span class="p">}</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">master</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="n">sha</span><span class="w"></span>
<span class="w">    </span><span class="p">}</span><span class="w"> </span><span class="k">else</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="n">panic</span><span class="o">!</span><span class="p">()</span><span class="w"></span>
<span class="w">    </span><span class="p">};</span><span class="w"></span>
<span class="w">    </span><span class="n">fork</span><span class="p">.</span><span class="n">create_ref</span><span class="p">(</span><span class="o">&amp;</span><span class="n">Reference</span>::<span class="n">Branch</span><span class="p">(</span><span class="s">&quot;ice-dummy&quot;</span><span class="p">.</span><span class="n">to_string</span><span class="p">()),</span><span class="w"> </span><span class="n">master</span><span class="p">).</span><span class="k">await</span><span class="o">?</span><span class="p">;</span><span class="w"></span>
<span class="w">    </span><span class="n">fork</span><span class="p">.</span><span class="n">create_file</span><span class="p">(</span><span class="s">&quot;ices/00000.rs&quot;</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;Test creating a file from Octocat&quot;</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;fn main() {}&quot;</span><span class="p">)</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">branch</span><span class="p">(</span><span class="s">&quot;ice-dummy&quot;</span><span class="p">)</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">send</span><span class="p">()</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="k">await</span><span class="o">?</span><span class="p">;</span><span class="w"></span>
<span class="w">    </span><span class="n">base</span><span class="p">.</span><span class="n">pulls</span><span class="p">()</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">create</span><span class="p">(</span><span class="s">&quot;Dummy ICE!&quot;</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;ice-dummy&quot;</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;master&quot;</span><span class="p">)</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">body</span><span class="p">(</span><span class="s">&quot;This is a fake new catastrophic avalanche of ICE!&quot;</span><span class="p">)</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="n">send</span><span class="p">()</span><span class="w"></span>
<span class="w">        </span><span class="p">.</span><span class="k">await</span><span class="o">?</span><span class="p">;</span><span class="w"></span>
<span class="w">    </span><span class="nb">Ok</span><span class="p">(())</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="198099595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099595">(May 19 2020 at 17:23)</a>:</h4>
<p>I would also love that in general for serde_json, its errors are basically useless as is in HTTP apps.</p>



<a name="198099731"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099731" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099731">(May 19 2020 at 17:24)</a>:</h4>
<p>I don't want to compare by hand <span aria-label="sob" class="emoji emoji-1f62d" role="img" title="sob">:sob:</span></p>



<a name="198099743"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099743" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099743">(May 19 2020 at 17:24)</a>:</h4>
<p>Too many fields :D</p>



<a name="198099760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099760">(May 19 2020 at 17:24)</a>:</h4>
<p><a href="https://docs.rs/serde_path_to_error/0.1.2/serde_path_to_error/">https://docs.rs/serde_path_to_error/0.1.2/serde_path_to_error/</a></p>



<a name="198099819"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099819" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099819">(May 19 2020 at 17:25)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="198099829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099829">(May 19 2020 at 17:25)</a>:</h4>
<p><span aria-label="surprise" class="emoji emoji-1f62e" role="img" title="surprise">:surprise:</span></p>



<a name="198099840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198099840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198099840">(May 19 2020 at 17:25)</a>:</h4>
<p><span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="198100036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100036">(May 19 2020 at 17:26)</a>:</h4>
<p>I'll try that out then</p>



<a name="198100120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100120">(May 19 2020 at 17:27)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> That example is great, even in that small example you used the library in a way I didn't think people would.</p>



<a name="198100292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100292">(May 19 2020 at 17:28)</a>:</h4>
<p>Well that's the beauty of open-source, right?</p>



<a name="198100370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100370">(May 19 2020 at 17:28)</a>:</h4>
<p>Also makes me increasingly confident in the builder pattern approach to the design.</p>



<a name="198100401"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100401" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100401">(May 19 2020 at 17:29)</a>:</h4>
<p>Oh there's another issue I wanted to talk about</p>



<a name="198100421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100421">(May 19 2020 at 17:29)</a>:</h4>
<p>Serde deserializes <code>None</code> into a <code>null</code> value</p>



<a name="198100454"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100454" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100454">(May 19 2020 at 17:29)</a>:</h4>
<p>Which doesn't make GitHub happy for certain cases</p>



<a name="198100470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100470">(May 19 2020 at 17:29)</a>:</h4>
<p>Oh yeah, but None is not "don't show up in the json"</p>



<a name="198100577"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100577" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100577">(May 19 2020 at 17:30)</a>:</h4>
<p>I think we'll need to slap some <code>#[serde(skip_serializing_if = "Option::is_none")]</code> everywhere in the lib</p>



<a name="198100603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100603">(May 19 2020 at 17:30)</a>:</h4>
<p>Because it triggered me some errors</p>



<a name="198100622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100622">(May 19 2020 at 17:30)</a>:</h4>
<p>And I'll probably not be the only one :D</p>



<a name="198100699"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100699" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100699">(May 19 2020 at 17:31)</a>:</h4>
<p>Feel free to add it as you need, I wish there was a way to set that somehow at the struct or library level, since I never want to serialize <code>None</code> as <code>null</code>.</p>



<a name="198100850"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100850" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100850">(May 19 2020 at 17:32)</a>:</h4>
<p>Maybe we can have our own <code>Option</code> type</p>



<a name="198100871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100871">(May 19 2020 at 17:32)</a>:</h4>
<p>Which doesn't deserialize as <code>null</code>?</p>



<a name="198100891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198100891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198100891">(May 19 2020 at 17:32)</a>:</h4>
<p>May be interesting <span aria-label="nerd" class="emoji emoji-1f913" role="img" title="nerd">:nerd:</span></p>



<a name="198101440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198101440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198101440">(May 19 2020 at 17:37)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> That would actually be an acceptable alternative. And it's actually easy to implement.</p>
<div class="codehilite"><pre><span></span><code><span class="cp">#[derive(Serialize)]</span><span class="w"></span>
<span class="cp">#[serde(untagged)]</span><span class="w"></span>
<span class="k">enum</span> <span class="nc">MyOption</span><span class="o">&lt;</span><span class="n">T</span><span class="o">&gt;</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">  </span><span class="nb">Some</span><span class="p">(</span><span class="n">T</span><span class="p">),</span><span class="w"></span>
<span class="w">  </span><span class="cp">#[serde(skip)]</span><span class="w"></span>
<span class="w">  </span><span class="nb">None</span><span class="p">,</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="198102921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198102921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198102921">(May 19 2020 at 17:49)</a>:</h4>
<p>/me wishes that github api had an actual spec so that we'd know when to do it</p>



<a name="198102996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198102996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198102996">(May 19 2020 at 17:50)</a>:</h4>
<p>I would personally avoid a custom option type, and much prefer the skip_serializing_if annotations</p>



<a name="198104125"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198104125" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198104125">(May 19 2020 at 17:59)</a>:</h4>
<p>Yeah, my solution does mean that it can basically be only used for serialisation, and you lose all of options methods. Thinking on it more the skip_serializing_if noise is fine. Maybe this is another thing a hypothetical proc macro would solve <a href="https://github.com/XAMPPRocky/octocrab/issues/11">XAMPPRocky/octocrab#11</a>.</p>



<a name="198107016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198107016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198107016">(May 19 2020 at 18:21)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> Back to your example, why did you create <code>fork</code> and <code>base</code>rather than using just one of those?</p>



<a name="198112060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198112060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198112060">(May 19 2020 at 19:03)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> Great work! I've been experimenting a bit myself, though I am not as experienced as you.</p>



<a name="198112558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198112558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198112558">(May 19 2020 at 19:07)</a>:</h4>
<blockquote>
<p><span class="user-mention silent" data-user-id="255061">LeSeulArtichaut</span> Back to your example, why did you create <code>fork</code> and <code>base</code>rather than using just one of those?</p>
</blockquote>
<p>Basically, I originally wanted to file a PR against the real rust-lang/glacier repo, but I didn’t want to make any noise so I changed it back to my fork. I let the two variables to make it easy to go back to having the PR agaist another repo.</p>



<a name="198123842"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198123842" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198123842">(May 19 2020 at 20:42)</a>:</h4>
<p>Ah makes sense.</p>



<a name="198123881"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198123881" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198123881">(May 19 2020 at 20:43)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> I'm filing a PR to integrate <code>serde_path_to_error</code> btw</p>



<a name="198124953"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198124953" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198124953">(May 19 2020 at 20:52)</a>:</h4>
<p><a href="https://github.com/XAMPPRocky/octocrab/issues/14">XAMPPRocky/octocrab#14</a></p>



<a name="198125943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198125943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198125943">(May 19 2020 at 21:00)</a>:</h4>
<p>(Ping <span class="user-mention" data-user-id="219696">@XAMPPRocky</span> <span aria-label="sweat smile" class="emoji emoji-1f605" role="img" title="sweat smile">:sweat_smile:</span>)</p>



<a name="198127288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198127288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198127288">(May 19 2020 at 21:11)</a>:</h4>
<p>Thanks! I can rebase my branches and get proper errors now :D</p>



<a name="198308108"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198308108" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198308108">(May 21 2020 at 10:54)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> I created a PR to address the review requests by XAMPP <a href="https://github.com/LeSeulArtichaut/octocrab/pull/1">https://github.com/LeSeulArtichaut/octocrab/pull/1</a></p>



<a name="198320639"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198320639" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198320639">(May 21 2020 at 13:32)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Thank you very much! To thank you I'll give you a small tip: instead of:</p>
<div class="codehilite"><pre><span></span><code><span class="k">fn</span> <span class="nf">fmt</span><span class="p">(</span><span class="o">&amp;</span><span class="bp">self</span><span class="p">,</span><span class="w"> </span><span class="n">f</span>: <span class="kp">&amp;</span><span class="nc">mut</span><span class="w"> </span><span class="n">std</span>::<span class="n">fmt</span>::<span class="n">Formatter</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="nc">std</span>::<span class="n">fmt</span>::<span class="nb">Result</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="n">f</span><span class="p">.</span><span class="n">write_str</span><span class="p">(</span><span class="o">&amp;</span><span class="n">format</span><span class="o">!</span><span class="p">(</span><span class="s">&quot;refs/{}&quot;</span><span class="p">,</span><span class="w"> </span><span class="bp">self</span><span class="p">.</span><span class="n">ref_url</span><span class="p">()))</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>


<p>You can write:</p>
<div class="codehilite"><pre><span></span><code><span class="k">fn</span> <span class="nf">fmt</span><span class="p">(</span><span class="o">&amp;</span><span class="bp">self</span><span class="p">,</span><span class="w"> </span><span class="n">f</span>: <span class="kp">&amp;</span><span class="nc">mut</span><span class="w"> </span><span class="n">std</span>::<span class="n">fmt</span>::<span class="n">Formatter</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="nc">std</span>::<span class="n">fmt</span>::<span class="nb">Result</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="n">write</span><span class="o">!</span><span class="p">(</span><span class="n">f</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;refs/{}&quot;</span><span class="p">,</span><span class="w"> </span><span class="bp">self</span><span class="p">.</span><span class="n">ref_url</span><span class="p">())</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="198323195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198323195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198323195">(May 21 2020 at 13:55)</a>:</h4>
<p>Interesting, thanks!</p>



<a name="198323364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198323364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198323364">(May 21 2020 at 13:57)</a>:</h4>
<p>Btw <a href="https://doc.rust-lang.org/stable/std/macro.write.html">here are the docs</a></p>



<a name="198350094"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198350094" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198350094">(May 21 2020 at 17:23)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> How often are octocrab releases made? I guess it wouldn't be acceptable to use a git dependency</p>



<a name="198350151"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198350151" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198350151">(May 21 2020 at 17:23)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Use a git dependency and tell me if your code works, and if it does I'll make a release soon.</p>



<a name="198354977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198354977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198354977">(May 21 2020 at 18:03)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> There is an issue, though:</p>
<div class="codehilite"><pre><span></span><code>error: failed to select a version for `base64`.
    ... required by package `postgres-protocol v0.5.1`
    ... which is depended on by `tokio-postgres v0.5.4`
    ... which is depended on by `postgres-native-tls v0.3.0`
    ... which is depended on by `triagebot v0.1.0 (/home/-snip-/projects/triagebot)`
versions that meet the requirements `= 0.12.0` are: 0.12.0

all possible versions conflict with previously selected packages.

  previously selected package `base64 v0.12.1`
    ... which is depended on by `octocrab v0.2.3 (https://github.com/XAMPPRocky/octocrab#077e39d3)`
    ... which is depended on by `triagebot v0.1.0 (/home/-snip-/projects/triagebot)`

failed to select a version for `base64` which could resolve this conflict
</code></pre></div>



<a name="198355143"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198355143" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198355143">(May 21 2020 at 18:04)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Fixed</p>



<a name="198355241"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198355241" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198355241">(May 21 2020 at 18:05)</a>:</h4>
<p>Thanks, it compiles now!</p>



<a name="198356060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356060">(May 21 2020 at 18:11)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> But does it run? <span aria-label="stuck out tongue wink" class="emoji emoji-1f61c" role="img" title="stuck out tongue wink">:stuck_out_tongue_wink:</span></p>



<a name="198356262"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356262" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356262">(May 21 2020 at 18:13)</a>:</h4>
<p>It might not :D</p>



<a name="198356304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356304">(May 21 2020 at 18:14)</a>:</h4>
<p>If we encounter problems with serializing <code>None</code>s or failing to deserialize requests from GitHub</p>



<a name="198356305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356305">(May 21 2020 at 18:14)</a>:</h4>
<p>Well, running it is a bit more difficult since that means setting up triagebot locally</p>



<a name="198356395"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356395" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356395">(May 21 2020 at 18:14)</a>:</h4>
<p>So far it compiles, at least, using the example by Artichaut with one small tweak (octograb.pulls instead of repo.pulls)</p>



<a name="198356473"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356473" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356473">(May 21 2020 at 18:15)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> Shall I go and mark all <code>Option</code>s in <code>Serialize</code> types as <code>#[serde(skip_serializing_if = "Option::is_none")]</code>?</p>



<a name="198356558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356558">(May 21 2020 at 18:16)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> What did you use Octocrab for, exactly?</p>



<a name="198356602"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356602" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356602">(May 21 2020 at 18:16)</a>:</h4>
<p>If you just used methods that I used in my example, it should be fine</p>



<a name="198356616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356616">(May 21 2020 at 18:16)</a>:</h4>
<p>I hope <span aria-label="fingers crossed" class="emoji emoji-1f91e" role="img" title="fingers crossed">:fingers_crossed:</span></p>



<a name="198356619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356619">(May 21 2020 at 18:16)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> Yes, but wait a moment. I'm about to push some code.</p>



<a name="198356642"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356642" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356642">(May 21 2020 at 18:16)</a>:</h4>
<p>Got it</p>



<a name="198356756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198356756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198356756">(May 21 2020 at 18:17)</a>:</h4>
<p>Pushed</p>



<a name="198357280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198357280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198357280">(May 21 2020 at 18:22)</a>:</h4>
<p>Oh actually I think we should have this patch:</p>
<div class="codehilite"><pre><span></span><code>diff --git a/src/api/pulls/create.rs b/src/api/pulls/create.rs
index 7c4c525..3783ec2 100644
--- a/src/api/pulls/create.rs
+++ b/src/api/pulls/create.rs
@@ -7,8 +7,11 @@ pub struct CreatePullRequestBuilder&lt;&#39;octo, &#39;b&gt; {
     title: String,
     head: String,
     base: String,
+    #[serde(skip_serializing_if = &quot;Option::is_none&quot;)]
     body: Option&lt;String&gt;,
+    #[serde(skip_serializing_if = &quot;Option::is_none&quot;)]
     draft: Option&lt;bool&gt;,
+    #[serde(skip_serializing_if = &quot;Option::is_none&quot;)]
     maintainer_can_modify: Option&lt;bool&gt;,
 }

diff --git a/src/models.rs b/src/models.rs
index 47bd694..660ab91 100644
--- a/src/models.rs
+++ b/src/models.rs
@@ -33,7 +33,7 @@ pub struct PullRequest {
     pub closed_at: Option&lt;chrono::DateTime&lt;chrono::Utc&gt;&gt;,
     pub mergeable: Option&lt;bool&gt;,
     pub merged_at: Option&lt;String&gt;,
-    pub merge_commit_sha: String,
+    pub merge_commit_sha: Option&lt;String&gt;,
     pub assignee: Option&lt;User&gt;,
     pub assignees: Vec&lt;User&gt;,
     pub requested_reviewers: Vec&lt;User&gt;,
</code></pre></div>



<a name="198357341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198357341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198357341">(May 21 2020 at 18:22)</a>:</h4>
<p>I forgot to include it in my repos PR</p>



<a name="198357375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198357375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198357375">(May 21 2020 at 18:22)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> Ping me here when you’ve made the PR, and I’ll release with those changes later today.</p>



<a name="198367325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198367325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198367325">(May 21 2020 at 19:47)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> opened <a href="https://github.com/XAMPPRocky/octocrab/issues/16">XAMPPRocky/octocrab#16</a></p>



<a name="198368663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198368663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198368663">(May 21 2020 at 19:58)</a>:</h4>
<p>That's a solid +226 lines xD</p>



<a name="198375960"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198375960" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198375960">(May 21 2020 at 20:52)</a>:</h4>
<p><span class="user-mention" data-user-id="255061">@LeSeulArtichaut</span> <span class="user-mention" data-user-id="219696">@XAMPPRocky</span> I made something that compiles and looks like it could work in my latest commit - <a href="https://github.com/rust-lang/triagebot/pull/526">https://github.com/rust-lang/triagebot/pull/526</a></p>



<a name="198376756"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198376756" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198376756">(May 21 2020 at 20:59)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> The builder struct is unused, so it won’t work as is. I’d recommend adding Octocrab to Context, and using that in your Handler implementation. <a href="https://github.com/rust-lang/triagebot/blob/2822adc8be10b5fd46b95fefe240e2b31f6e3e62/src/handlers.rs">https://github.com/rust-lang/triagebot/blob/2822adc8be10b5fd46b95fefe240e2b31f6e3e62/src/handlers.rs</a></p>



<a name="198396226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198396226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198396226">(May 22 2020 at 00:50)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> I've published 0.3 to <a href="http://crates.io">crates.io</a></p>



<a name="198438344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198438344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198438344">(May 22 2020 at 13:02)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> Is there a way to check if a branch exists?</p>



<a name="198438760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198438760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198438760">(May 22 2020 at 13:07)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Yes, with <code>Octocrab::repos::get_ref</code>. E.g</p>
<div class="codehilite"><pre><span></span><code><span class="k">if</span><span class="w"> </span><span class="n">octocrab</span><span class="p">.</span><span class="n">repos</span><span class="p">(</span><span class="s">&quot;owner&quot;</span><span class="p">,</span><span class="w"> </span><span class="s">&quot;repo&quot;</span><span class="p">).</span><span class="n">get_ref</span><span class="p">(</span><span class="o">&amp;</span><span class="n">Reference</span>::<span class="n">Branch</span><span class="p">(</span><span class="s">&quot;master&quot;</span><span class="p">)).</span><span class="n">is_ok</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="w">  </span><span class="c1">// branch exists</span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="198439449"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198439449" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198439449">(May 22 2020 at 13:14)</a>:</h4>
<p>Will it give a specific error if it doesn't exist (rather than for example if ratelimit was reached)</p>



<a name="198439848"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198439848" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198439848">(May 22 2020 at 13:19)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> Is there a reason you're enabling "full" on tokio's features? That brings in things like signal handling which, well, seems like a bit of waste dependency wise :)</p>



<a name="198439919"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198439919" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198439919">(May 22 2020 at 13:19)</a>:</h4>
<p>No reason.</p>



<a name="198440060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198440060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198440060">(May 22 2020 at 13:20)</a>:</h4>
<p>Really I shouldn't be pulling in tokio directly at all, I'm only using it in examples and tests.</p>



<a name="198440232"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198440232" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198440232">(May 22 2020 at 13:22)</a>:</h4>
<p>Would this be an use case for dev dependencies?</p>



<a name="198440291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198440291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198440291">(May 22 2020 at 13:23)</a>:</h4>
<p>Ah okay, would be good to fix that :)</p>
<p>re:the glacier PR, I just left a comment there as well but happy to merge that with a <a href="http://crates.io">crates.io</a> dep for octocrab</p>



<a name="198440294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198440294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198440294">(May 22 2020 at 13:23)</a>:</h4>
<p>no rush of course</p>



<a name="198441127"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198441127" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198441127">(May 22 2020 at 13:31)</a>:</h4>
<p>I'm publishing 0.3.1 that moves tokio to dev-dependencies now.</p>



<a name="198441294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198441294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198441294">(May 22 2020 at 13:33)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> IIRC in my testing create_ref doesn’t error if the ref exists</p>



<a name="198441327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198441327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198441327">(May 22 2020 at 13:33)</a>:</h4>
<p>I will do some testing when I have time later today</p>



<a name="198441634"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198441634" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198441634">(May 22 2020 at 13:36)</a>:</h4>
<p>Yeah I tried looking into that, and neither GitHub's nor Git's documentation give any real indication on whether it would work or fail.</p>



<a name="198441998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198441998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198441998">(May 22 2020 at 13:40)</a>:</h4>
<p>At least its still better than reddit's API</p>



<a name="198442044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198442044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198442044">(May 22 2020 at 13:40)</a>:</h4>
<p><em>documentation is hard</em></p>



<a name="198455698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198455698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198455698">(May 22 2020 at 15:36)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Sorry for the stupid question but what does "r=me" mean?</p>



<a name="198455963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198455963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198455963">(May 22 2020 at 15:38)</a>:</h4>
<p>will merge when whatever I said was done</p>



<a name="198457621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198457621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198457621">(May 22 2020 at 15:51)</a>:</h4>
<p>I'm going to test creating a branch that exists</p>



<a name="198459540"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198459540" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198459540">(May 22 2020 at 16:05)</a>:</h4>
<p>Here's the GitHub response if the branch already exists:</p>
<div class="codehilite"><pre><span></span><code>{
  &quot;message&quot;: &quot;Reference already exists&quot;,
  &quot;documentation_url&quot;: &quot;https://developer.github.com/v3/git/refs/#create-a-reference&quot;
}
</code></pre></div>


<p>Which means octocrab will return an <code>Err(Error::Github)</code>.</p>



<a name="198462295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198462295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198462295">(May 22 2020 at 16:24)</a>:</h4>
<p>Alright, I think I should be able to incorporate that, thanks a lot Artichaut!</p>



<a name="198462335"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198462335" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198462335">(May 22 2020 at 16:24)</a>:</h4>
<p>You're welcome ;)</p>



<a name="198462356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198462356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198462356">(May 22 2020 at 16:24)</a>:</h4>
<p>By the way do you speak French? :P</p>



<a name="198466901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198466901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198466901">(May 22 2020 at 17:01)</a>:</h4>
<p>Unfortunately not :c</p>



<a name="198467166"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198467166" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198467166">(May 22 2020 at 17:03)</a>:</h4>
<p>I thought you did :D</p>



<a name="198469592"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198469592" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198469592">(May 22 2020 at 17:23)</a>:</h4>
<p>:P</p>



<a name="198469660"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198469660" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198469660">(May 22 2020 at 17:24)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> What can I help with on octocrab?</p>



<a name="198470288"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198470288" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198470288">(May 22 2020 at 17:29)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> The most helpful thing right now is adding more methods for different endpoints. Generally how I have been doing it is going to <a href="https://octokit.github.io/rest.js/v17/">https://octokit.github.io/rest.js/v17/</a> Picking a section and going through and implementing the different methods.</p>



<a name="198471961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198471961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198471961">(May 22 2020 at 17:42)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> <span class="user-mention" data-user-id="116122">@simulacrum</span> Should we add a page in the wiki for the glacier command?</p>



<a name="198471972"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198471972" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198471972">(May 22 2020 at 17:42)</a>:</h4>
<p>yes please do!</p>



<a name="198472833"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198472833" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198472833">(May 22 2020 at 17:49)</a>:</h4>
<p>Sure!</p>



<a name="198500582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198500582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198500582">(May 22 2020 at 22:10)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> Can I make the error fields public? Right now I can't match on them</p>



<a name="198500884"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/198500884" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#198500884">(May 22 2020 at 22:13)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> Yeah go ahead, if you could also add <code>#[non_exhaustive]</code> to the struct that’s be great.</p>



<a name="199310742"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/199310742" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#199310742">(May 31 2020 at 15:52)</a>:</h4>
<p><span class="user-mention" data-user-id="219696">@XAMPPRocky</span> Does the <code>instance()</code> work now?</p>



<a name="199310748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/199310748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#199310748">(May 31 2020 at 15:53)</a>:</h4>
<p><span class="user-mention" data-user-id="301348">@Elinvynia</span> What do you mean?</p>



<a name="199310814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/199310814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#199310814">(May 31 2020 at 15:55)</a>:</h4>
<p>The "build the instance then use it anywhere"</p>



<a name="199310859"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/199310859" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#199310859">(May 31 2020 at 15:56)</a>:</h4>
<p>I think <span class="user-mention silent" data-user-id="116122">simulacrum</span> didn't want to use static instances in Triagebot</p>



<a name="199310864"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/199310864" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#199310864">(May 31 2020 at 15:56)</a>:</h4>
<p>Yes whenever I've done that sort of thing in the past it's just led to trouble later down the line</p>



<a name="199310877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/199310877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#199310877">(May 31 2020 at 15:57)</a>:</h4>
<p>not really entirely sure I feel that it belongs in octocrab either vs. having people roll their own given how relatively easy it is</p>



<a name="199310924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/224082-t-release/triagebot/topic/Transition%20to%20the%20Octocrab%20GitHub%20API/near/199310924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Elinvynia <a href="https://rust-lang.github.io/zulip_archive/stream/224082-t-release/triagebot/topic/Transition.20to.20the.20Octocrab.20GitHub.20API.html#199310924">(May 31 2020 at 15:58)</a>:</h4>
<p>Oh I thought the issue was it not working rather than it being a decision to avoid it</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>